I set this aside for most of the week but got back to it Friday. I replaced the current PPMC algorithm with the one that Athena++ uses and it seems to be working. All the linear waves look right and the Sod shock tube at least passes. The Einfeldt Strong Rarefaction doesn’t, after a handful of time steps it has negative pressure and divergence issues. In the first time step the Y magnetic field is wrong so I’ve been chasing that down and have narrowed it down to one of the electric fields, I’ll figure that out next week.
Once I’ve got it working 100% I need to do some cleanup on the current method as it’s pretty much just copied and pasted from Athena++ and doesn’t really work well with Cholla.
I have a committee meeting soon so I spent part of the week prepping for that; writing reports, getting paperwork, etc.
Now that I have working MHD code with PLMC and access to Frontier it’s time to run some scaling tests! I’m still waiting on the largest two tests to run but the results from the rest are very promising and show excellent performance. You can find the repo with all my scaling tests stuff here.
- Automated testing fix. Turns out that the webhook settings weren’t right. No idea why it was working before
- Get tests working on Frontier. PR #295