Paper Writing & Debugging PPMC Tests
Paper Writing
This week I finished the shock tube figures, or at least the minimum viable product version of them. After that I spent a day writing up the sections on the linear wave convergence and Riemann problem tests.
Concatenation Script
The file concatenation script we had required manual changes to work and I want to use it in some of my paper scripts so I added a CLI and python interface to it PR #303.
PR Rebasing and Testing
This week my PLMC PR was merged into dev so I needed to rebase my last clang-tidy PR and my PPMC PR. This process required some changes for the clang-tidy checks that were enabled and revealed some issues with PPMC related tests. Several of the tests for PPMC components or things that depend on it had subtle bugs that were only present when I switched systems. Those are all fixed now and the clang-tidy PR is merged and the PPMC one should be in soon. I also wrote a test for checking the linear wave convergence rate but I haven’t submitted a PR for that.