Linear Waves and Best Practices

Linear Wave Debugging

I finished linear wave tests, they needed a bit of polishing. With some help I discovered that the perturbations I was seeing in the Alfven wave tests weren’t an issue since they also appear in Athena++. The fast magnetosonic and contact waves are both correct as well now. The slow magnetosonic wave might be working but there appear to be some issues in the initial conditions so I’m not sure yet.

MHD also passes hydro wave tests and the Sod shock tube.

Scientific Software Best Practices

I presented on scientific software best practices based off of:

• Wilson et al. 2014
• Wilson et al. 2017
• Software Engineering’s Greatest Hits by Greg Wilson of Wilson et al.

Other

• Solved ROCm bug ROCm issue #1842. I was using the wrong function. The correct function wasn’t documented. Shout out to Damon McDougall for finding the issue.
• Update website to v5.3.1
• Fix some typos in the HLLD Algorithm post
• Read The Circumgalactic Medium by Tumlinson et al. 2017 for class