After cleaning up a few things based on the review this PR (#300) is merged!
I enabled a handful of checks, including some of the naming checks, in PR #309. With Helena’s help this led to a bit of a rabbit hole where I discovered that our
HeaderFilterRegex for clang-tidy was wrong and was excluding some of our headers and not just system+library headers. This in turn led me to discovering that the cluster that runs our automated testing doesn’t have support for OpenMP on their clang installation. They’ve been very helpful and that should be fixed soon.
I found a small bug in the initial conditions for the Orszag-Tang vortex and fixed it in PR #311.
After some more digging I discovered that the Grafana GUI for Omniperf is currently broken, or at least the docker container I need for it is, and OLCF doesn’t support the built in GUI. CLI interface is the only option at the moment.
The advecting field loop plots are done. I’ve also added a first draft for the text for the advecting field loop, circularly polarized Alfvén wave, MHD blast wave, and Orszag-Tang vortex.