MHD Debugging & Compute Sanitizer
MHD Debugging It looks like the weird edge effect issues I was seeing might just be oscillations due to the higher order Van Leer method as it’s present in hydro builds as well. It turns out that...
MHD Debugging It looks like the weird edge effect issues I was seeing might just be oscillations due to the higher order Van Leer method as it’s present in hydro builds as well. It turns out that...
HLLD Refactor I finished refactoring the HLLD solver to use structs instead of scalar variables this week (PR #237). It uses a few less registers now, is much more readable, and several hundred li...
Automated Testing I spent about half of this week getting automated testing working with Jenkins. I had some issues with clang-tidy’s header filtering not working properly but after that it was mo...
Clang Tools The clang tools PR (PR #211) has been merged! At the beginning of this week I rebased it for the other PRs that have been added and I wrote a script to help summarize the output of cla...
MHD Sod Bug The 4 rank MHD Sod test isn’t passing. I’ve been trying to figure out why and, after a lot of digging, it looks like there’s an issue in the HLLD solver near the boundaries. 32 time st...
MHD Refactor This week has mostly been addressing issues raised in the code review of my MHD PR. Mostly that was moving some functions out of Grid3D and into the MHD namespace, adding comments, ci...
Clang Tools I made some tweaks to the clang tools PR (#211) to get it ready. I removed the clang-tidy run on ROCm since it’s not working. If we figure out how to get it working I’ll add it back. I...
This week I worked on my final project for class and gave a presentation with Evan for the Crusher User Experience Talks at OLCF.
MHD Boundary Conditions (BC) I fixed several bugs in the MHD boundary conditions and so transmissive and periodic boundaries appear to be working now. This also allowed me to remove almost all the...
Clang-Format I set up our clang-format settings file, wrote a bash script to run it on all our C++ files, and made a GitHub Action to check if a commit is properly formatted that will run on every...